Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slot to GridPoint conversion was very reliant on the containers being Chest based. To tackle this I introduced the idea of a GridMapper which sole responsibility is to turn slots into GridPoints and GridPoints into slots.
With this change we don't need ordered pane anymore as all slots used by the pane will already be mapped when passing it to the pane.
A few things to note:
fromBukkitPlayerSlot
andrelativizePlayerInventorySlot
because I am not exactly sure how they interact and from my testing they were never called or the results were always the same as the mapper.