Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

IDB fixes #552

Merged
merged 7 commits into from
Nov 6, 2019
Merged

IDB fixes #552

merged 7 commits into from
Nov 6, 2019

Conversation

radex
Copy link
Collaborator

@radex radex commented Nov 4, 2019 •
edited
Loading

  • Bump LokiJS - fixes IndexedDB race conditions when deleting DB
  • fix an issue that maybe caused CI failures in NT
  • add callback that allows apps to force app to log out if db was deleted in another tab

@radex radex self-assigned this Nov 4, 2019
@radex radex assigned kamilkoza and unassigned radex and kamilkoza Nov 4, 2019
@radex radex requested a review from rkrajewski November 4, 2019 11:11
rozPierog
rozPierog approved these changes Nov 6, 2019
View reviewed changes
Copy link
Contributor

@rozPierog rozPierog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks okay, but there is an conflict with package.json

@rozPierog rozPierog assigned radex and unassigned rkrajewski Nov 6, 2019
@radex radex assigned rozPierog and unassigned radex Nov 6, 2019
@radex radex merged commit 5f7dc29 into master Nov 6, 2019
@radex radex deleted the idb-fixes2 branch November 6, 2019 15:26
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@rozPierog rozPierog rozPierog approved these changes

@rkrajewski rkrajewski Awaiting requested review from rkrajewski

Assignees

@rozPierog rozPierog

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@radex @rozPierog @rkrajewski @kamilkoza