Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

New preset "ASCII_FULL_CONDENSED" #97

Merged
merged 2 commits into from
Dec 30, 2022
Merged

New preset "ASCII_FULL_CONDENSED" #97

merged 2 commits into from
Dec 30, 2022

Conversation

alexander-beedie
Copy link
Contributor

@alexander-beedie alexander-beedie commented Dec 30, 2022

New preset:
I really should have submitted this alongside the preset added in #94 ... 😅

Here's the ASCII equivalent of the previously introduced UTF8_FULL_CONDENSED; as before, it matches its corresponding FULL variant, just without the row dividers:

# ASCII_FULL:          ASCII_FULL_CONDENSED:
# +-------+-------+    +-------+-------+
# | Hello | there |    | Hello | there |
# +===============+    +===============+
# | a     | b     |    | a     | b     |
# |-------+-------|    | c     | d     |
# | c     | d     |    | e     | f     |
# |-------+-------|    +-------+-------+
# | e     | f     |
# +-------+-------+

Also:
Fixed two lines in utils/arrangement/mod.rs that triggered the new iter_kv_map clippy lint:

// before
infos.into_iter().map(|(_, info)| info).collect()

// after
infos.into_values().collect()

Thanks!

@codecov-commenter
Copy link

codecov-commenter commented Dec 30, 2022

Codecov Report

Merging #97 (b735bf8) into main (2c018c3) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #97   +/-   ##
=======================================
  Coverage   96.01%   96.01%           
=======================================
  Files          17       17           
  Lines        1605     1605           
=======================================
  Hits         1541     1541           
  Misses         64       64           
Impacted Files Coverage Δ
src/utils/arrangement/mod.rs 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Nukesor
Copy link
Owner

Nukesor commented Dec 30, 2022

Hi! Thanks for your contribution :)

PR looks perfectly fine and has proper tests.
Thanks for fixing those new clippy issues!

I'll publish a point release momentarily.

@Nukesor Nukesor merged commit b4204fb into Nukesor:main Dec 30, 2022
@Nukesor
Copy link
Owner

Nukesor commented Dec 31, 2022

New release is out :)

@alexander-beedie
Copy link
Contributor Author

New release is out :)

Fantastic - thanks for the super-quick turnaround! (and a Happy New Year to you ;)

@alexander-beedie alexander-beedie deleted the ascii-condensed-preset branch March 12, 2023 15:15
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants