Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

more granular nextHopProtocol cases #1

Merged
merged 6 commits into from
Oct 19, 2024
Merged

Conversation

wesinator
Copy link
Contributor

handle http/1.x explicitly, separate from empty protocol value
it seems some http/1.1 sites return a blank nextHopProtocol, but the official 1.1 value is http/1.1:

https://developer.mozilla.org/docs/Web/API/PerformanceResourceTiming/nextHopProtocol#value

@wesinator wesinator mentioned this pull request Jun 28, 2024
@NyeUsr
Copy link
Owner

NyeUsr commented Aug 8, 2024

Awesome, thank you! Is there a reason for

Might be good to merge #1 and release before merging this and bumping to a new version.

As mentioned in #2 ? Both changes seem to work as an update when combined together.

@wesinator
Copy link
Contributor Author

Ah, yes it would be fine to do both in one. I just didn't know if you wanted to separate the changes.
You could release one more Manifest v2 extension with this functionality change, then merge the mv3 and make a new release.

@NyeUsr NyeUsr merged commit d54b778 into NyeUsr:main Oct 19, 2024
@wesinator wesinator deleted the patch-1 branch October 20, 2024 03:07
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants