-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Make PathItem operation properties specific #2127
Conversation
As the primary author of recent drafts of the JSON Schema spec, this is not an abuse of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aye from me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Danger Will Robinson! This PR is against the OpenAPI.next
branch. I do not believe any merges are scheduled from this branch. @webron please advise correct branch (and maybe we can remove OpenAPI.next
?
@MikeRalphson hmm sorry! Issue sems worse since the modification comes FROM OpenApi.next, which is unmerged into master. So let me solve it, I will create proper PR. But which work branch to choose? DEVELOPMENT.md:47 and README.md:24 seem to tell me to use 3.1.0-dev - non breaking change - instead of 3.0.3-dev - typos or clarifications - but none of that branch contain the v3 schema ¿? |
That guidance is for changes to the specification. The schema is non-normative, so I think |
Avoid misuse of `patternProperties` feature. Fix OAI#2126
599549e
to
9efdced
Compare
@MikeRalphson PR source force updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aye from me. Thanks for rebasing.
Should this also be merged into v3.1/schema*, as the same keyword usage exists there? |
Wouldn't hurt... |
(port of PR OAI#2127 to v3.1)
(port of PR OAI#2127 to v3.2)
PR for #2126.
Move the Operations properties definitions from
patternProperties
to theproperties
set, explicitly defining all of them. The goal is to get better coding tools completion - IntelliJ IDEA does - and to improve the spec quality with a purer spec schema usage.Changes are 100% backwards compatible, all validating schemas will validate and all non validating schemas won't validate after merge. After merge, coding tools will get more information because of replacing a pattern with a defined literal set.