[18.0][MIG] account_move_tier_validation:Migration to 18 #1921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-invoicing-14.0/account-invoicing-14.0-account_move_tier_validation Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-14-0/account-invoicing-14-0-account_move_tier_validation/
* 'Validation In Progress' so as to allow an easy location of the invoices for which a validation has been triggered, but it is not yet completed. * 'Validation Not Started' to locate bills that either require no validation, or the request for validation has not yet been initiated.
…not working correctly
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-invoicing-14.0/account-invoicing-14.0-account_move_tier_validation Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-14-0/account-invoicing-14-0-account_move_tier_validation/
Currently translated at 100.0% (27 of 27 strings) Translation: account-invoicing-14.0/account-invoicing-14.0-account_move_tier_validation Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-14-0/account-invoicing-14-0-account_move_tier_validation/sv/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-invoicing-15.0/account-invoicing-15.0-account_move_tier_validation Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-15-0/account-invoicing-15-0-account_move_tier_validation/
…lidation, rejection
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-invoicing-15.0/account-invoicing-15.0-account_move_tier_validation Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-15-0/account-invoicing-15-0-account_move_tier_validation/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-invoicing-16.0/account-invoicing-16.0-account_move_tier_validation Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-account_move_tier_validation/
Currently translated at 100.0% (26 of 26 strings) Translation: account-invoicing-16.0/account-invoicing-16.0-account_move_tier_validation Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-account_move_tier_validation/es/
Currently translated at 100.0% (27 of 27 strings) Translation: account-invoicing-16.0/account-invoicing-16.0-account_move_tier_validation Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-account_move_tier_validation/es/
Currently translated at 100.0% (27 of 27 strings) Translation: account-invoicing-16.0/account-invoicing-16.0-account_move_tier_validation Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-account_move_tier_validation/sv/
…moves with tier validation Added tests for changes Updated error to be checked in tests Updated error to be checked in tests
Currently translated at 100.0% (28 of 28 strings) Translation: account-invoicing-16.0/account-invoicing-16.0-account_move_tier_validation Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-account_move_tier_validation/it/
Edit a new journal entry with lines in currency X different from company currency Y. Say you have a line of value (amount_currency) N, which is converted to Y(N) (debit/credit). Then `amount_total` is also N. Because the `readonly="not(review_ids)"` was added, `amount_total` is dirty and sent at save. Therefore, Odoo uses it and sets the debit/credit values of the lines to N (instead of Y(N), the converted value). It's as if it's ignoring the currency conversion (note that the values are correct through onchange before the save). To avoid this, exclude the field from being modified in `get_view`.
celm1990
suggested changes
Feb 22, 2025
There was a problem hiding this comment.
LGTM, just a minor change
@xaviedoanhduy @pedrobaeza @bosd @StefanRijnhart could you please review this?
Comment on lines
+13
to
+17
| class TestAccountTierValidation(TransactionCase): | ||
| @classmethod | ||
| def setUpClass(cls): | ||
| super().setUpClass() | ||
| cls.env = cls.env(context=dict(cls.env.context, **DISABLED_MAIL_CONTEXT)) |
There was a problem hiding this comment.
This class can inherit from BaseCommon, allowing setUpClass to be removed.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace #1830