[17] account_reconcile_oca : Forward port multi currency management from 16 #788
Conversation
|
Hi @etobella, |
|
Yes, I am waiting @etobella On this one! |
| partial = partial_lines.filtered( | ||
| lambda r: r.debit_move_id == reconciled_line | ||
| or r.credit_move_id == reconciled_line | ||
| ) |
There was a problem hiding this comment.
| partial = partial_lines.filtered( | |
| lambda r: r.debit_move_id == reconciled_line | |
| or r.credit_move_id == reconciled_line | |
| ) | |
| partial = partial_lines.filtered( | |
| lambda r, line=reconciled_line: r.debit_move_id == line | |
| or r.credit_move_id == line | |
| ) |
Doing something like this will fix the pre-commit
|
Can you also add the changes from #792? |
|
Pre-commit is fixed and and #792 added. |
|
Please squash some commits together like the linter fix with the code that originates the linter the error for merging this. |
We will use currency of the line in order to get the suspense and max line value
Fix the case of payment with a foreign currency set on bank statement line improve tests around multi-currency
…rrency rate It is possible that the statement line in foreign currency is created before the rate of the day is updated in Odoo. In this case we need to take the real rate of the statement line to comput the exchange rate
…wanted currency conversion
…ount If currency amount is not 0, the suspense line will have wrong amount
…er_id without onchange or subsequent changes with the _synchronize_to_moves() method. We do not define partner_id with the value of manual_partner_id to prevent _synchronize_to_moves() from making changes to the account.move.line leaving unintended values and/or data. Re-define the value of reconcile_data_info if the _synchronize_to_moves() method has changed anything on the lines. Related to OCA#779 TT52634
We need to look at the reconcile_data to find the partner as the manual_partner_id can contain the information of an auxiliary line
florian-dacosta
force-pushed
the
17-fix-mcurr-port
branch
from
2ac6252 to
3ae9775
Compare
We cant to avoid to change amounts on accounting entries during the reconciliation process. One of the goal is to avoid a following case : The statement line is created in a foreign currency journal, later, the rate is updated in Odoo. During reconciliation process, the partner is set on liquidity line, the accounting entries are synchronized and the balance changes.
florian-dacosta
force-pushed
the
17-fix-mcurr-port
branch
from
3ae9775 to
56f9072
Compare
I have squashed this one. |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 5a0cfa1. Thanks a lot for contributing to OCA. ❤️ |
@etobella @pedrobaeza
Pre-commit is failing because of a part coming from 62d508b#diff-4032c7e70261a4eb503cedc278a75ad0b0d8e20843b621b4e9bae34a2426f153
I am not comfortable at all with this part, could you take a look @etobella ?
Forward port of #694
Include also :
Multi-currency is still quite buggy, but it makes main use cases ok at least.