[18.0][MIG] account_reconcile_oca #808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JordiBForgeFlow
force-pushed
the
18.0-mig-account_reconcile_oca
branch
from
3aec596 to
43f87b4
Compare
* In "reconcile" tab, don't propose the move of the currently processed statement line * In accounting, only select/search parent partners
* refactoring JS in order to add logic * Improve views * Minor fixes in Odoo code in order to fix all possible options
…of account move number (name) fot the counterpart account move line
Currently translated at 1.0% (1 of 92 strings) Translation: account-reconcile-16.0/account-reconcile-16.0-account_reconcile_oca Translate-URL: https://translation.odoo-community.org/projects/account-reconcile-16-0/account-reconcile-16-0-account_reconcile_oca/es/
Currently translated at 25.0% (23 of 92 strings) Translation: account-reconcile-16.0/account-reconcile-16.0-account_reconcile_oca Translate-URL: https://translation.odoo-community.org/projects/account-reconcile-16-0/account-reconcile-16-0-account_reconcile_oca/hr/
Currently translated at 81.5% (75 of 92 strings) Translation: account-reconcile-16.0/account-reconcile-16.0-account_reconcile_oca Translate-URL: https://translation.odoo-community.org/projects/account-reconcile-16-0/account-reconcile-16-0-account_reconcile_oca/tr/
By default, account_account name is a char field. But if l10n_multilang is installed, it is translatable, hence the DB column is now a jsonb. We must handle both cases in the select query.
Currently translated at 76.0% (70 of 92 strings) Translation: account-reconcile-16.0/account-reconcile-16.0-account_reconcile_oca Translate-URL: https://translation.odoo-community.org/projects/account-reconcile-16-0/account-reconcile-16-0-account_reconcile_oca/pt_BR/
Currently translated at 100.0% (92 of 92 strings) Translation: account-reconcile-16.0/account-reconcile-16.0-account_reconcile_oca Translate-URL: https://translation.odoo-community.org/projects/account-reconcile-16-0/account-reconcile-16-0-account_reconcile_oca/fr/
…ifferent currency
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-reconcile-17.0/account-reconcile-17.0-account_reconcile_oca Translate-URL: https://translation.odoo-community.org/projects/account-reconcile-17-0/account-reconcile-17-0-account_reconcile_oca/
Currently translated at 100.0% (122 of 122 strings) Translation: account-reconcile-17.0/account-reconcile-17.0-account_reconcile_oca Translate-URL: https://translation.odoo-community.org/projects/account-reconcile-17-0/account-reconcile-17-0-account_reconcile_oca/it/
… log WARNING prod py.warnings: /opt/odoo/auto/addons/account_reconcile_oca/models/account_bank_statement_line.py:616: DeprecationWarning: Since 17.0, deprecated method, read display_name instead
… to avoid warning log WARNING prod py.warnings: /opt/odoo/auto/addons/account/models/account_move.py:4651: UserWarning: unsupported operand type(s) for "==": 'res.partner()' == '403'
JordiBForgeFlow
force-pushed
the
18.0-mig-account_reconcile_oca
branch
from
43f87b4 to
203719b
Compare
JordiBForgeFlow
force-pushed
the
18.0-mig-account_reconcile_oca
branch
from
203719b to
d4b9d8f
Compare
|
@etobella All is green here |
|
Please, cherry-pick #809 to commit history |
…_get_reconcile_line()
Example use case:
File "/opt/odoo/auto/addons/account_reconcile_oca/models/account_bank_statement_line.py", line 541, in _compute_reconcile_data_info
record.reconcile_data_info = record._default_reconcile_data(
File "/opt/odoo/auto/addons/account_reconcile_oca/models/account_bank_statement_line.py", line 698, in _default_reconcile_data
reconcile_auxiliary_id, lines = self._get_reconcile_line(
File "/opt/odoo/auto/addons/account_reconcile_oca/models/account_bank_statement_line.py", line 1164, in _get_reconcile_line
new_vals = super()._get_reconcile_line(
File "/opt/odoo/auto/addons/account_reconcile_oca/models/account_reconcile_abstract.py", line 49, in _get_reconcile_line
original_amount = amount = net_amount = line.debit - line.credit
File "/opt/odoo/custom/src/odoo/odoo/fields.py", line 1154, in __get__
record.ensure_one()
File "/opt/odoo/custom/src/odoo/odoo/models.py", line 5204, in ensure_one
raise ValueError("Expected singleton: %s" % self)
ValueError: Expected singleton: account.move.line(208, 211, 212)
TT55221
@victoralmau Done! |
pedrobaeza
approved these changes
Mar 2, 2025
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 8de3e44. Thanks a lot for contributing to OCA. ❤️ |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #785
Dependencies: