Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Corrections on the export of tracking numbers: #16

Merged
merged 5 commits into from
Sep 26, 2014

Conversation

guewen
Copy link
Member

@guewen guewen commented Jul 15, 2014

  • avoid to send twice a tracking number
  • when a tracking's job is executed before the export of the picking,
    the tracking's job export the picking

@@ -196,6 +196,8 @@ def run(self, binding_id):
Export the picking to Magento
"""
picking = self.session.browse(self.model._name, binding_id)
if picking.magento_id:
return _('Already exported')

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the .pot files?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The export of translation in OpenERP didn't exported the terms, I added them manually in the pot file

@guewen
Copy link
Member Author

guewen commented Aug 19, 2014

Rebased

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.29%) when pulling 7b00256 on guewen:7.0-export-tracking into 0596e3a on OCA:7.0.

@bwrsandman
Copy link

👍

1 similar comment
@gurneyalex
Copy link
Member

👍

guewen added 5 commits August 22, 2014 09:10
When the tracking number was written after the picking has been set to
'done', but before the job to export the picking was executed, the job
that export the picking was exporting the tracking number, but another
job was created to export the tracking number as well.
Now, the picking' job only exports the tracking number if it was already
there when the picking was set to 'done' (because in that case, the
second job is not created).
@guewen guewen force-pushed the 7.0-export-tracking branch from 7b00256 to 274f743 Compare August 22, 2014 07:13
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.29%) when pulling 274f743 on guewen:7.0-export-tracking into 0596e3a on OCA:7.0.

nbessi added a commit that referenced this pull request Sep 26, 2014
Corrections on the export of tracking numbers:
@nbessi nbessi merged commit 35a1993 into OCA:7.0 Sep 26, 2014
@nbessi
Copy link

nbessi commented Sep 26, 2014

👍

jcoux pushed a commit to camptocamp/connector-magento that referenced this pull request May 14, 2019
Pickings can be imported into inactive products
saxomanu pushed a commit to saxomanu/connector-magento that referenced this pull request May 25, 2020
[FIX] not sale_line in stock_picking
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants