Catch cases where record['discount_amount'] = None #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if record.get('discount_amount'): | ||
| discount_value = float(record.get('discount_amount', 0)) | ||
| if self.backend_record.catalog_price_tax_included and \ | ||
| record.get('row_total_incl_tax'): |
There was a problem hiding this comment.
Also do not put a \ but use parentheses
|
I propose to leave the existing code but just use this idiom |
|
@guewen , @pedrobaeza : yes, it's cleaner like this. I fixed it. |
|
Thanks! 👍 |
|
👍 |
guewen
added a commit
that referenced
this pull request
Dec 16, 2014
Catch cases where record['discount_amount'] = None
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Magento sometimes sends sales_order.items with the attributes 'discount_amount' set to None; this caused the float() function to fail with the error "TypeError: float() argument must be a string or a number".