Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

CLAbot weird error #394

Closed
pedrobaeza opened this issue Nov 16, 2018 · 10 comments
Closed

CLAbot weird error #394

pedrobaeza opened this issue Nov 16, 2018 · 10 comments
Assignees

Comments

@pedrobaeza
Copy link
Member

@gurneyalex there's something weird with the CLAbot. Check the comment OCA/stock-logistics-workflow#470 (comment).

It says my colleague is not found in the CLAs. First thing I have checked is that commits are with the proper email:

seleccion_009

and you can see also that GitHub recognizes them with the GitHub profile sergio-teruel.

seleccion_010

and finally, on OCA instance the contact is properly setup:

seleccion_011

so I don't have any clue on what's going on.

Can you please check?

@gurneyalex
Copy link
Member

@pedrobaeza could there be 2 partners in our database with the same github login, one without a CLA ?

@pedrobaeza
Copy link
Member Author

No, I tried that also. Sorry for not mentioning.

@LoisRForgeFlow
Copy link

Similar issue here: OCA/product-attribute#399 (comment)

@gurneyalex gurneyalex self-assigned this Nov 18, 2018
@gurneyalex
Copy link
Member

I'll look into this today

@pedrobaeza
Copy link
Member Author

Maybe this is because the mail is not public and CLAbot is not able to deduce the github login from the commit information?

@gurneyalex
Copy link
Member

My analysis of the issue : it seems that on the PR, the github login of some of the commits is lost. It may be related to rebase or rebase merge or cherry pick, I'm not sure. In these cases the clabot is not fetching the correct information. I'm working on a fix.

@pedrobaeza
Copy link
Member Author

OK, thanks for the followup

@gurneyalex
Copy link
Member

@pedrobaeza Discussion on the fix at OCA/oca-github-bot#22

@gurneyalex
Copy link
Member

for the record, a fix has been deployed for this issue

@pedrobaeza
Copy link
Member Author

Closing as merged.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants