Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[12.0][MIG] product manufacturer #399

Merged
merged 16 commits into from
Nov 8, 2018
Merged

[12.0][MIG] product manufacturer #399

merged 16 commits into from
Nov 8, 2018

Conversation

Menestrels
Copy link

Migration of product_manufacturer from 11.0 to 12.0.

acysos and others added 16 commits October 29, 2018 17:39
@acysos
[ADD] product_manufacturer: add module removed in Odoo 8.0
1903e36
@oscarolar
[IMP] product_manufacturer: Several
9db032b 
* New Field Added to store the URL of the product on the manufacturer page.
* Added field manufacturer product URL to the product view.
* README updated.
@yvaucher
[FIX] product_manufacturer: Add license to manifest + icons
a233b42
@pedrobaeza
[IMP] product_manufacturer: URL widget for product URL
f579390
@gurneyalex
Add OCA as author of OCA addons
c810d25 
In order to get visibility on https://www.odoo.com/apps the OCA board has
decided to add the OCA as author of all the addons maintained as part of the
association.
@hbrunn
[ADD] migration for product_manufacturer
101ad92
@paulius-sladkevicius
product_manufacturer: update view to meet v9
63b16c5
@raycarnes
Port to v10
5fe5f08
@bistaray
several fixes
34cca5c 
Add # -*- encoding: utf-8 -*-
@oca-transbot
OCA Transbot updated translations from Transifex
a36f5b8
@MiquelRForgeFlow
[8.0][FIX/MIG] product_manufacturer
5f99440
@LoisRForgeFlow
[11.0][MIG] product_manufacturer
9a9801e
@oca-transbot
OCA Transbot updated translations from Transifex
e019650
@sbidoul
remove obsolete .pot files [ci skip]
33a165d
@oca-travis
[UPD] Update product_manufacturer.pot
42a6324
[MIG] product_manufacturer: Migration to 12.0
2c110ec
@oca-clabot
Copy link

Hey @Menestrels, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

  • Lois Rilo (no github login found)
  • Ray Carnes (no github login found)
  • Daniels Andersons (no github login found)

Appreciation of efforts,
OCA CLAbot

@pedrobaeza pedrobaeza added this to the 12.0 milestone Oct 30, 2018
@OCA-git-bot OCA-git-bot mentioned this pull request Oct 30, 2018
Closed
24 tasks
@LoisRForgeFlow
Copy link
Contributor

LoisRForgeFlow commented Oct 30, 2018 •
edited
Loading

Lois Rilo (no github login found)

@pedrobaeza @sbidoul it's not a big deal, but why the bot is saying that I don't have CLA signed? In all my own PRs I haven't had any problem so my CLA must be in place.

@pedrobaeza
Copy link
Member

Have you changed the mail in the commits through this time (maybe from personal to professional one)?

@LoisRForgeFlow
Copy link
Contributor

No, I didn't this github account was created with my professional mail and never changed.

@pedrobaeza
Copy link
Member

Clone this branch and see through git log what is the defined email for being sure.

@LoisRForgeFlow
Copy link
Contributor

Everything seems good:

image

@pedrobaeza
Copy link
Member

Then the only hypothesis is OCA bot glitch 😛

@LoisRForgeFlow
Copy link
Contributor

seems so, we have a 🐛

mlaitinen
mlaitinen approved these changes Oct 31, 2018
View reviewed changes
Copy link

@mlaitinen mlaitinen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

hegenator
hegenator approved these changes Nov 1, 2018
View reviewed changes
Copy link

@hegenator hegenator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pedrobaeza pedrobaeza merged commit a9d1475 into OCA:12.0 Nov 8, 2018
@Menestrels Menestrels deleted the 12.0-mig-product_manufacturer branch November 8, 2018 09:31
@LoisRForgeFlow LoisRForgeFlow mentioned this pull request Nov 16, 2018
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@mlaitinen mlaitinen mlaitinen approved these changes

@hegenator hegenator hegenator approved these changes

Assignees
No one assigned
Labels
needs review
Projects
None yet
Milestone
12.0
Development

Successfully merging this pull request may close these issues.