Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[IMP] product_tax_multicompany_default: beautier and mass propagation #464

Merged
merged 1 commit into from
Mar 28, 2023
Merged

[IMP] product_tax_multicompany_default: beautier and mass propagation #464

merged 1 commit into from
Mar 28, 2023

Conversation

yajo
Copy link
Member

@yajo yajo commented Mar 21, 2023

  • Propagate button was ugly. It's prettier now.

    before after
    flameshot_2023-03-21_11-24 flameshot_2023-03-21_11-42

  • Add ability to filter products that have divergent cross-company taxes.

  • Allow propagating massively.

@moduon MT-2586

@OCA-git-bot
Copy link
Contributor

Hi @Shide,
some modules you are maintaining are being modified, check this out!

@yajo
[IMP] product_tax_multicompany_default: beautier and mass propagation
d924a7a 
- Propagate button was ugly. It's prettier now.
- Add ability to filter products that have divergent cross-company taxes.
- Allow propagating massively.

@moduon MT-2586
@yajo yajo force-pushed the 14.0-product_tax_multicompany_default-mass_beautier_propagation branch from 36f5e0f to d924a7a Compare March 21, 2023 13:21
@rafaelbn
Copy link
Member

Tested in runboat, doesn't work in my test

imagen

@yajo
Copy link
Member Author

yajo commented Mar 22, 2023 via email

@yajo
Copy link
Member Author

yajo commented Mar 22, 2023

Please also make sure that you have full accounting permissions. Just like before this patch, the option will not be shown unless you have that group. Remember that it is hidden unless you use Enterprise, so you have to go to the group itself and add the user, instead of doing it the other way around:

image

I added that group to admin in current runboat. Please try now.

fcvalgar
fcvalgar approved these changes Mar 22, 2023
View reviewed changes
Copy link

@fcvalgar fcvalgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @yajo

rafaelbn
rafaelbn approved these changes Mar 22, 2023
View reviewed changes
Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested 👍 in runbot

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@rafaelbn
Copy link
Member

@etobella could you please make a quick review here please?

etobella
etobella approved these changes Mar 28, 2023
View reviewed changes
Copy link
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Technically

@etobella
Copy link
Member

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-464-by-etobella-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit b4bdb29 into OCA:14.0 Mar 28, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 013eba3. Thanks a lot for contributing to OCA. ❤️

@yajo yajo deleted the 14.0-product_tax_multicompany_default-mass_beautier_propagation branch April 4, 2023 06:27
This was referenced Apr 4, 2023
Merged
Open
Merged
@sebalix sebalix mentioned this pull request May 3, 2023
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@etobella etobella etobella approved these changes

@fcvalgar fcvalgar fcvalgar approved these changes

@rafaelbn rafaelbn rafaelbn approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yajo @OCA-git-bot @rafaelbn @etobella @fcvalgar