Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[ADD] Add error message chart_template_ref argument has been removed in v18 #101

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[ADD] Add error message chart_template_ref argument has been removed in v18 #101

wants to merge 1 commit into from
+2 −0

Conversation

lef-adhoc
Copy link
Contributor

More info here

@lef-adhoc
Copy link
Contributor Author

lef-adhoc commented Oct 17, 2024 •
edited
Loading

@legalsylvain @bruno-zanotti @jjscarafia @pedrobaeza
Could you check this ?

legalsylvain
legalsylvain reviewed Oct 17, 2024
View reviewed changes
odoo_module_migrate/migration_scripts/text_errors/migrate_170_180/chart_template_ref.yaml Outdated
@@ -0,0 +1,2 @@
.py:
chart_template_ref: "[18] The 'chart_template_ref' argument has been removed from setUpClass. More details: https://github.com/odoo/odoo/pull/152899"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe a more precise regex. something like

Suggested change
chart_template_ref: "[18] The 'chart_template_ref' argument has been removed from setUpClass. More details: https://github.com/odoo/odoo/pull/152899"
chart_template_ref: "[18] The 'setUpClass.*chart_template_ref' argument has been removed from setUpClass. More details: https://github.com/odoo/odoo/pull/152899"

don't you think?

Copy link
Contributor Author

@lef-adhoc lef-adhoc Oct 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be this way?
py: setUpClass.*chart_template_ref: "[18] The 'chart_template_ref' argument..

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@lef-adhoc
Copy link
Contributor Author

@legalsylvain Do you see it clearly now?

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@legalsylvain legalsylvain legalsylvain left review comments

@matiasperalta1 matiasperalta1 matiasperalta1 approved these changes

@lav-adhoc lav-adhoc lav-adhoc approved these changes

Assignees
No one assigned
Labels
approved ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lef-adhoc @OCA-git-bot @legalsylvain @matiasperalta1 @lav-adhoc