Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[IMP] *: add warning for auto-added invisible/readonly fields in XML views #116

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lef-adhoc
Copy link
Contributor

More details: odoo/odoo#137031

@@ -0,0 +1,2 @@
.xml:
invisible=(["']1["']|["']True["'])|column_invisible=(["']1["']|["']True["']): "[18] Fields that are required by Python expressions (invisible, column_invisible, readonly, required, context, domain) are now added automatically as invisible and readonly. You can remove these fields from XML views unless they are necessary for specific logic. More details: https://github.com/odoo/odoo/pull/137031."

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In xml code "True" and "true" are synonymous

Suggested change
invisible=(["']1["']|["']True["'])|column_invisible=(["']1["']|["']True["']): "[18] Fields that are required by Python expressions (invisible, column_invisible, readonly, required, context, domain) are now added automatically as invisible and readonly. You can remove these fields from XML views unless they are necessary for specific logic. More details: https://github.com/odoo/odoo/pull/137031."
invisible=(["']1["']|["']True["']|["']true["'])|column_invisible=(["']1["']|["']True["']|["']true["']): "[18] Fields that are required by Python expressions (invisible, column_invisible, readonly, required, context, domain) are now added automatically as invisible and readonly. You can remove these fields from XML views unless they are necessary for specific logic. More details: https://github.com/odoo/odoo/pull/137031."

@lef-adhoc
Copy link
Contributor Author

@thienvh332 There it is corrected

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants