Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[MIG]migration with commit history for product_code_unique module from v11 to V12 #411

Merged
merged 3 commits into from
Feb 11, 2019

Conversation

bizzappdev
Copy link
Contributor

migration from v11 to 12
#389

Copy link
Member

@nikul-serpentcs nikul-serpentcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improve Code

product_code_unique/__init__.py Outdated Show resolved Hide resolved
product_code_unique/__manifest__.py Outdated Show resolved Hide resolved
product_code_unique/__manifest__.py Outdated Show resolved Hide resolved
@bizzappdev
Copy link
Contributor Author

changes, as suggested, are done.

@bizzappdev
Copy link
Contributor Author

@nikul-serpentcs Please review again.

@nikul-serpentcs
Copy link
Member

@nikul-serpentcs Please review again.

@bizzappdev Squash commits

Copy link
Contributor

@alan196 alan196 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review 👍 just squash the commits

@bizzappdev bizzappdev force-pushed the 12.0-mig-product_code_unique branch from f22c83a to 591381b Compare February 11, 2019 05:26
@bizzappdev
Copy link
Contributor Author

squash Of the commits is done.

Copy link
Member

@nikul-serpentcs nikul-serpentcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza pedrobaeza merged commit cfa74d5 into OCA:12.0 Feb 11, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants