-
-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[12.0][MIG] Migrated product_code_mandatory to v12 #413
[12.0][MIG] Migrated product_code_mandatory to v12 #413
Conversation
* [ADD] Module to set the internal reference of the product as required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review 👍
@@ -0,0 +1,67 @@ | |||
.. image:: https://img.shields.io/badge/license-AGPL--3-blue.png |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please use the new split readme maintainer-tools and generate readme from it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fragmented readme, bot will generate the readme file
</field> | ||
</record> | ||
|
||
<record id="product_normal_form_code_mandatory_view" model="ir.ui.view"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aesthetic change (optional): use original_id
In the case where an inherited view has a name which does not follow the guidelines set above, prefer naming the inherited view after the original over using a name which follows the guidelines.
<?xml version="1.0" encoding="UTF-8"?> | ||
<odoo> | ||
|
||
<record id="product_template_only_form_code_mandatory_view" model="ir.ui.view"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aesthetic change (optional): use original_id
In the case where an inherited view has a name which does not follow the guidelines set above, prefer naming the inherited view after the original over using a name which follows the guidelines.
This PR has the |
@sudhir-erpharbor please squash your commits into one and it's good to go |
58118c9
to
0cbd84b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merge ok!
/ocabot merge |
What a great day to merge this nice PR. Let's do it! |
Congratulations, your PR was merged at a591ff2. Thanks a lot for contributing to OCA. ❤️ |
Please review and give feedback.