Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[12.0][MIG] Migrated product_code_mandatory to v12 #413

Merged
merged 3 commits into from
Feb 28, 2020

Conversation

sudhir-erpharbor
Copy link
Contributor

Please review and give feedback.

agyamuta and others added 2 commits December 4, 2018 12:03
* [ADD] Module to set the  internal reference of the product as required.
@pedrobaeza pedrobaeza added this to the 12.0 milestone Dec 4, 2018
@OCA-git-bot OCA-git-bot mentioned this pull request Dec 4, 2018
24 tasks
Copy link
Contributor

@alan196 alan196 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review 👍

@@ -0,0 +1,67 @@
.. image:: https://img.shields.io/badge/license-AGPL--3-blue.png
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use the new split readme maintainer-tools and generate readme from it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fragmented readme, bot will generate the readme file

</field>
</record>

<record id="product_normal_form_code_mandatory_view" model="ir.ui.view">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aesthetic change (optional): use original_id

In the case where an inherited view has a name which does not follow the guidelines set above, prefer naming the inherited view after the original over using a name which follows the guidelines.

<?xml version="1.0" encoding="UTF-8"?>
<odoo>

<record id="product_template_only_form_code_mandatory_view" model="ir.ui.view">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aesthetic change (optional): use original_id

In the case where an inherited view has a name which does not follow the guidelines set above, prefer naming the inherited view after the original over using a name which follows the guidelines.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@tbaden
Copy link
Member

tbaden commented May 15, 2019

@sudhir-erpharbor please squash your commits into one and it's good to go

@sudhir-erpharbor sudhir-erpharbor force-pushed the 12.0-product_code_mandatory branch from 58118c9 to 0cbd84b Compare May 20, 2019 06:33
Copy link
Contributor

@andreampiovesana andreampiovesana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge ok!

@simahawk
Copy link
Contributor

/ocabot merge

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 12.0-ocabot-merge-pr-413-by-simahawk-bump-no, awaiting test results.

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at a591ff2. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot OCA-git-bot merged commit a92dbde into OCA:12.0 Feb 28, 2020
@sudhir-erpharbor sudhir-erpharbor deleted the 12.0-product_code_mandatory branch February 28, 2020 08:12
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants