Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[12.0] [MIG] product_state #428

Merged
merged 6 commits into from
May 14, 2019
Merged

[12.0] [MIG] product_state #428

merged 6 commits into from
May 14, 2019

Conversation

Nikul-Chaudhary
Copy link
Member

Product State

This module introduces the state field on product template and allows simple product life cycle.

@Nikul-Chaudhary Nikul-Chaudhary mentioned this pull request Jan 29, 2019
Closed
24 tasks
@pedrobaeza pedrobaeza added this to the 12.0 milestone Jan 29, 2019
@Nikul-Chaudhary
Copy link
Member Author

@OCA/product-maintainers could you please review code?

rousseldenis
rousseldenis reviewed Mar 27, 2019
View reviewed changes
product_state/__manifest__.py
@@ -2,12 +2,12 @@
# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl.html).
{
'name': "Product State",
'description': """
'summary': """
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nikul-Chaudhary Could you use README generator ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rousseldenis @OCA-git-bot is automatically generated.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nikul-Chaudhary only if you use README fragments

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rousseldenis Done

tbaden
tbaden reviewed Apr 26, 2019
View reviewed changes
Copy link
Member

@tbaden tbaden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please generate the readme via maintainer tools

@rousseldenis
Copy link
Contributor

can you please generate the readme via maintainer tools

@tbaden Here, @Nikul-Chaudhary wrotes fragments, so, README will be generated depending on them (he could have generated README too, but not mandatory as it will be automatically be done by bot).

tbaden
tbaden approved these changes Apr 26, 2019
View reviewed changes
Copy link
Member

@tbaden tbaden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this info @rousseldenis

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

sebalix
sebalix approved these changes May 2, 2019
View reviewed changes
Copy link
Contributor

@sebalix sebalix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guewen guewen merged commit 1ae9187 into OCA:12.0 May 14, 2019
@Nikul-Chaudhary Nikul-Chaudhary deleted the 12-mig-product_state branch September 19, 2019 11:13
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@rousseldenis rousseldenis rousseldenis approved these changes

@guewen guewen guewen approved these changes

@sebalix sebalix sebalix approved these changes

@tbaden tbaden tbaden approved these changes

@i-vyshnevska i-vyshnevska i-vyshnevska approved these changes

Assignees
No one assigned
Labels
approved ready to merge
Projects
None yet
Milestone
12.0
Development

Successfully merging this pull request may close these issues.