Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[12.0] [MIG] product_pricelist_supplierinfo #429

Merged
merged 8 commits into from
Dec 30, 2019
Merged

[12.0] [MIG] product_pricelist_supplierinfo #429

merged 8 commits into from
Dec 30, 2019

Conversation

Nikul-Chaudhary
Copy link
Member

Supplier info prices in sales pricelists

This module allows you to create a sales pricelist based on product supplierinfo prices. If you want, you can bypass minimum quantity in pricelist
item.

@Nikul-Chaudhary Nikul-Chaudhary mentioned this pull request Jan 29, 2019
Closed
24 tasks
@pedrobaeza pedrobaeza added this to the 12.0 milestone Jan 29, 2019
@Nikul-Chaudhary
Copy link
Member Author

@OCA/product-maintainers could you please review code?

@Nikul-Chaudhary
Copy link
Member Author

@pedrobaeza @cubells @emagdalenaC2i Could you please review it?

tbaden
tbaden approved these changes Apr 26, 2019
View reviewed changes
Copy link
Member

@tbaden tbaden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code review: lgtm

@pedrobaeza
Copy link
Member

Can you improve a bit the test coverage?

@Nikul-Chaudhary Nikul-Chaudhary force-pushed the 12-mig-product_pricelist_supplierinfo branch from 70e6e33 to 8d6d861 Compare June 20, 2019 10:38
@Nikul-Chaudhary
Copy link
Member Author

@pedrobaeza @tbaden Could you please review again?

@Nikul-Chaudhary
Copy link
Member Author

@rafaelbn Can you please review it.

@Nikul-Chaudhary
Copy link
Member Author

@pedrobaeza @rafaelbn if you don't mind, can you please review it?

@pedrobaeza
Copy link
Member

@Nikul-Chaudhary can you attend my comments?

cubells and others added 7 commits December 21, 2019 11:11
@cubells @Nikul-Chaudhary
product_pricelist_supplierinfo: priceslists based in supplier info
b82adcf
@pedrobaeza @Nikul-Chaudhary
product_pricelist_supplierinfo: Several enhancements + concept fixing
fa7e772 
* Don't depend on sales
* Extended README
* Tests focused on module specific features
* Code optimization
* Don't mix pricelist info with supplier info on criteria
@OCA-git-bot @Nikul-Chaudhary
README.rst
c55f07f
@oca-travis @Nikul-Chaudhary
Update product_pricelist_supplierinfo.pot
3e0852f
@oca-transbot @Nikul-Chaudhary
Update translation files
58099e7 
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
@pedrobaeza @Nikul-Chaudhary
product_pricelist_supplierinfo: Take into account sales order date
04580c1 
Date order is passed by context, so we have to take this into account for
computing properly available supplierinfo records.
@pedrobaeza @Nikul-Chaudhary
product_pricelist_supplierinfo: Give more priority in order to min_qty
366db6d 
If not, you can twist the order in the form and rules won't be applied according criteria
@Nikul-Chaudhary Nikul-Chaudhary force-pushed the 12-mig-product_pricelist_supplierinfo branch from 8d6d861 to 7acced1 Compare December 21, 2019 05:42
@Nikul-Chaudhary Nikul-Chaudhary force-pushed the 12-mig-product_pricelist_supplierinfo branch from d07d485 to ff48c42 Compare December 21, 2019 06:40
@Nikul-Chaudhary
Copy link
Member Author

@pedrobaeza now ready to merge

@pedrobaeza
Copy link
Member

/ocabot merge

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 12.0-ocabot-merge-pr-429-by-pedrobaeza-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Dec 30, 2019
@OCA-git-bot
Merge PR #429 into 12.0
8c4e5e5 
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot OCA-git-bot merged commit ff48c42 into OCA:12.0 Dec 30, 2019
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at e9491b4. Thanks a lot for contributing to OCA. ❤️

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@tbaden tbaden tbaden approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
12.0
Development

Successfully merging this pull request may close these issues.
7 participants
@Nikul-Chaudhary @pedrobaeza @OCA-git-bot @tbaden @cubells @oca-travis @oca-transbot