[MIG][12.0] product_template_tags #448
Conversation
|
@patrickrwilson LGTM, Please Improve above changes. |
|
I believe I implemented all the reviewers changes. Is there anything I missed? |
There was a problem hiding this comment.
thanks for the work 👍
i did a code review: lgtm
if you want to please do these aesthetic changes (see below), but not blocking
@patrickrwilson please squash your commits into one
@nikul-serpentcs changes were made, anything else or good to go?
|
Thanks @tbaden, I will make these changes Monday morning. |
[UPD] Suggested Changes Updated code based on reviews [UPD] Add readme folder Added readme folder and made it so tags can be colored. [UPD] Aesthetic Changes Aesthetic changes requested from reviewer.
|
I made the suggested aesthetic changes and squashed the commits. |
|
.@max3903 I see history have been squashed. The initial author lost its commits isn't? |
|
@bealdav Here Only squashed the last commit which our works commit, Not all history (Other Commits). because Other commits are not shown which is committed by the original author or other important commits. |
Migration of product_template_tags to v12