[12.0][MIG] product_pricelist_revision: Migration to 12.0 #524
Conversation
ernestotejeda
force-pushed
the
12.0-mig-product_pricelist_revision
branch
3 times, most recently
from
fadce36 to
825bb37
Compare
There was a problem hiding this comment.
My feeling here is that there are 2 features in this module: the revision one, which is OK with some comments, and a hidden one that is listing pricelist items, that must go into a separate module. @carlosdauden why is this in the module?
|
This module adds a Tree view of 'Pricelist items' so that users can select one or more 'Pricelist items' and then create copies of them with a variation in their 'fixed price', so maybe there are not 2 features in this module. The problem here is that the search view of 'Pricelist items' defined here includes the 'name' field which is a computed field. As it is a computed field we have specify a method in the search argument in the field definition |
|
OK, I see. Then that should be explained better in the README. Please add also coverage for the uncovered parts like that search. |
ernestotejeda
force-pushed
the
12.0-mig-product_pricelist_revision
branch
2 times, most recently
from
58b3a5d to
f9478b0
Compare
pedrobaeza
force-pushed
the
12.0-mig-product_pricelist_revision
branch
from
f9478b0 to
e581cc7
Compare
|
/ocabot merge |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 78bae31. Thanks a lot for contributing to OCA. ❤️ |
Cc @Tecnativa TT20175