Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

test_workspace: use different asset w/ loctype URL #1305

Merged
merged 13 commits into from
Feb 18, 2025
Merged

test_workspace: use different asset w/ loctype URL #1305

merged 13 commits into from
Feb 18, 2025

Conversation

bertsky
Copy link
Collaborator

@bertsky bertsky commented Feb 14, 2025

No description provided.

@bertsky bertsky requested a review from kba February 14, 2025 13:05
@bertsky
Copy link
Collaborator Author

bertsky commented Feb 17, 2025 •
edited
Loading

I have now test-covered both issues.

@kba these warrant a new 3.0.4 IMO.

For the changelog, I would recommend:

Changed

  • mets_server: downgrade log messages (INFO→DEBUG)

Fixed

  • mets_server: make add_file (POST /file) work with pageId=None
  • ocrd_page: serialization of OrderedGroup/* namespace prefixes
  • run_processor: handle frozendict and empty parameter when logging

Added

  • tests for processors with add_file(... page_id=None ...)
  • tests for ocrd_page roundtrip
  • tests for processor logging

@bertsky bertsky force-pushed the fix-test-workspace-download1 branch from 5857de1 to 7bc2f4c Compare February 17, 2025 10:21
kba
kba approved these changes Feb 17, 2025
View reviewed changes
Copy link
Member

@kba kba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing now.

src/ocrd_page_user_methods/_exportChildren_GroupType.py
@@ -26,4 +26,4 @@ def replaceWithRRI(group):
else:
cleaned.append(entry)
for entry in cleaned:
entry.export(outfile, level, entry.ns_prefix_, namespacedef_='', name_=entry.__class__.__name__[:-4], pretty_print=pretty_print)
entry.export(outfile, level, namespaceprefix_, namespacedef_='', name_=entry.__class__.__name__[:-4], pretty_print=pretty_print)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eek, well done to find this.

@bertsky bertsky force-pushed the fix-test-workspace-download1 branch from f0de566 to ec9cd01 Compare February 17, 2025 13:09
@bertsky bertsky mentioned this pull request Feb 17, 2025
Draft
6 tasks
@kba kba merged commit 5238b3f into OCR-D:master Feb 18, 2025
21 checks passed
@kba kba deleted the fix-test-workspace-download1 branch February 18, 2025 18:01
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@kba kba kba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bertsky @kba