Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Upstreaming changes #32

Merged
merged 28 commits into from
Sep 4, 2019
Merged

Conversation

raphael-proust
Copy link
Contributor

These are all the commits from the tezos repository (https://gitlab.com/tezos/tezos) that made changes to the vendored ocplib-json-typed. A merge commit reconciles work from the vendored and upstream version.

klakplok and others added 26 commits September 2, 2019 15:41
Co-authored-by: Pietro Abate <pietro.abate@nomadic-labs.com>
Co-authored-by: Gregoire Henry <gregoire.henry@tezos.com>
It now uses dune and "wraps" its library.
We don't care as we're not using the Makefile directly but:
dune: --dev is no longer accepted as it is now the default.
- ocaml.4.07.1
- lwt.4.1.0
- dune.1.7.1

These need to be updated all at once due to incompatibilities
in our dependencies

Author: Grégoire Henry <gregoire.henry@tezos.com>
By @abate

- [Protocol compiler]: Minor change to dune file
- fix opam file of tezos-client-demo
- add install in opam files for lib_resto-directory & lib_resto
- makes it feasible to extract all vendors/ packages to an opam repository
- Vendors: specify double [[ in build fields in opam files
NOTE: This is only to have uniform opam files.
Co-authored-by: Pietro Abate <pietro.abate@nomadic-labs.com.com>
Co-authored-by: Raphaël Proust <code@bnwr.net>
@chambart
Copy link
Member

chambart commented Sep 3, 2019

Are you certain about the merge commit. There seems to be nothing else than opam files changes and some comments ?

@raphael-proust
Copy link
Contributor Author

On tezos' master:

$ git ls-tree HEAD:vendors/ocplib-json-typed
100644 blob 66026b6e74b8af2216ca698bd7bf8f1d53b336d5    LICENSE
100644 blob d56625796277b4edba6e4c40dff188acf658fd47    Makefile
100644 blob 147d7858b9023b369a5b1741239b8c0018e96b00    README.md
100644 blob 41555900a5fae97ebd0df3c3504ebec22b817550    ocplib-json-typed-browser.opam
100644 blob fc76ed5169b640b05c25ff1f24063dcca9e35b8a    ocplib-json-typed-bson.opam
100644 blob a06170234a6f149aca01875eafba0cde465515c2    ocplib-json-typed.opam
040000 tree 598a2911cd1f11add5a947c89e79e373cf7c45e5    src

On this here branch:

$ git ls-tree 0cb130c9
100644 blob 5d125ace5d97839c0dc9fe6a2f0054c075992f76    .gitignore
100644 blob 1b742ad9e50a12cafa076de0d085d044f0b89c49    .travis.yml
100644 blob 66026b6e74b8af2216ca698bd7bf8f1d53b336d5    LICENSE
100644 blob d56625796277b4edba6e4c40dff188acf658fd47    Makefile
100644 blob 147d7858b9023b369a5b1741239b8c0018e96b00    README.md
100644 blob 41555900a5fae97ebd0df3c3504ebec22b817550    ocplib-json-typed-browser.opam
100644 blob fc76ed5169b640b05c25ff1f24063dcca9e35b8a    ocplib-json-typed-bson.opam
100644 blob a06170234a6f149aca01875eafba0cde465515c2    ocplib-json-typed.opam
040000 tree 598a2911cd1f11add5a947c89e79e373cf7c45e5    src

The 0cb130c9 commit (the one just before the merge) carries exactly the same source files (src hashes to 598a2911cd1f11add5a947c89e79e373cf7c45e5) as tezos' master's HEAD.


IIUC, there's been some up- and down-streaming of patches in this project. Hence the very similar sources and the short diff.

@chambart
Copy link
Member

chambart commented Sep 4, 2019

Ok then, it's good to go. It probably don't require a new release right now.

@chambart chambart merged commit 0d9e9cd into OCamlPro:master Sep 4, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants