Show the correct URL when OGSpy is installed behind a reverse Proxy #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darknoon29
approved these changes
Oct 4, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sadly using
PHP_SELFandHTTP_HOSTonly works when OGspy is served directly by a HTTP server (Apache or whatever else).This patch adds support to have OGSpy behind a reverse proxy.
Useful, for example, if OGSpy is on a container and HTTPS is provided by the reverse proxy.
As a bonus, the plugin is now able to detect (in mos cases) the protocol. The port is only added to the URL if it's not the standard port for the protocol being used.