-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Observation_concept_id should not be conditions, procedures, drugs or devices #635
Comments
Note that Christian adds Specimen and Visit to the list of domains not in observation: https://forums.ohdsi.org/t/there-are-not-enough-observation-concept-id-in-the-omop-cdm/8396/4?u=andy_kanter |
Issue # and locationIssue summary
Convention typeTable CDM table
CDM field
Links to issue discussionProvenance of dataGeneral The ratified conventionAlthough the general convention is that the domain of the concept should match the domain of the table, the observation table can contain a mix of concept domains. The only rule is that records with Concepts in the Condition, Procedure, Drug, Measurement, Specimen, Visit or Device domains should NOT be included as observations, but go to their corresponding table. Observation concepts should be standard concepts as usual. Date of ratification/publishedNA Downstream implicationsIn Atlas cohort definitions, when selecting the observation table in a criteria, it should be allowed to select a concept_id from any domain. Link to DQD checkYes - fkDomain. Related conventions/further informationTo insert: link to general convention of mapping concepts to respective domains. #Tags |
To the reviewer: this convention is actually an exception to the general convention that concept domain should match table, i.e. "Records with concepts from domain condition, procedure, drug, visit, specimen or device have to go to corresponding tables." |
@clairblacketer There is conflicting information in our documentation about which concepts/domains can live in the observation_concept_id field. |
@MelaniePhilofsky and @MaximMoinat I don't think we need to be prescriptive to the point of listing all the possible domains that could go in the observation table. We should give more context around what the Observation table is used for, reiterate the movement of records based on condition, drug, procedure, measurement, device, specimen, and then describe ways the Observation table is used like 'history of', marital status, tobacco use, etc. I will add this to the CDM docs |
Observation_concept_id
CDM or THEMIS convention?
CDM
Table or Field level?
Field
Is this a general convention?
Does this convention apply to the model at large or perhaps applies to multiple fields (i.e. how datetimes are represented)
No
Summary of issues
Summary of answer
This is a foreign key of the CONCEPT_ID that the OBSERVATION_SOURCE_CONCEPT_ID maps to. The only rule is that records with Concepts in the Condition, Procedure, Drug, Measurement, or Device domains should NOT be included as observations, but go to their corresponding table (Problems/diagnoses/conditions to the Condition_occurance table, procedures to procedure_occurance, etc.
Observation concepts should be standard concepts as usual.
Related links
[- Put any links you have found related to this convention]
Other comments/notes
The text was updated successfully, but these errors were encountered: