Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Enable PC and DPC for source and non-standard concepts #2258

Merged
merged 2 commits into from
May 2, 2023

Conversation

TomWhite-MedStar
Copy link
Contributor

This, in combination with a pull request # 721 for Achilles,
It solves the issue discussed in this forum post.
I confirmed that this works on my Databricks instance.

@TomWhite-MedStar
Copy link
Contributor Author

@chrisknoll , per discussion, removed Achilles analysis # 40

@anthonysena
Copy link
Collaborator

Thanks @TomWhite-MedStar for this contribution! I'd like to wait and see the outcome of OHDSI/Achilles#721. Assuming that is approved and the analyses you've added are included, we'll be able to merge this into WebAPI.

@TomWhite-MedStar
Copy link
Contributor Author

Thanks. @anthonysena , or @chrisknoll , Do you need any more information from me about OHDSI/Achilles#721?

@anthonysena
Copy link
Collaborator

I think we're set on the WebAPI side @TomWhite-MedStar. I just want to make sure that the analysis IDs referenced in the WebAPI query are the ones that are finalized in Achilles. I know that we could merge this in now but in the off-chance that the Achilles folks have any desire to change analysis IDs for some reason, we'd have to patch this up.

@chrisknoll
Copy link
Collaborator

chrisknoll commented May 2, 2023

I think it'll be a low possibility that they will object to the analysis_ids so how about we accept it here with that slight risk, and if they do change the analysis_ids, we can patch.

@anthonysena
Copy link
Collaborator

That's good by me thanks @chrisknoll

@chrisknoll chrisknoll merged commit dc75ede into OHDSI:master May 2, 2023
anton-abushkevich pushed a commit that referenced this pull request May 4, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants