htp/table: only fetch element when needed #430
Conversation
It is unnecessary to always fetch the element as it is only needed when there is a match. Get the list item only when the key candidate matches the key parameter and the element needs to be returned. This will ensure lesser calls to htp_list_get fn.
|
Information: QA ran without warnings. Pipeline 22052 |
|
Is there a ticket for this ? A benchmark/profile ? |
Nope. Observed this while looking at your report for 7191.
None. Just seemed to make logical sense to me. wdyt?
Sure. Almalinux? I can only find that we removed CentOS 7 in Suricata, I guess newer versions were already there in the CI there. |
It makes sense.
@jasonish thoughts ? |
|
Information: QA ran without warnings. Pipeline 22056 |
I think we should have AlmaLinux 9 at least. Maybe even 8 as well. |
ok. Thank you! Coming up in next rev |
It is unnecessary to always fetch the element as it is only needed when there is a match. Get the list item only when the key candidate matches the key parameter and the element needs to be returned. This will ensure lesser calls to htp_list_get fn.