lua: use lua from crates.io rather than github - v2 #11762
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the source override in .cargo/config.toml to apply to the suricata-lua-sys crate as well fixing offline builds. Ticket: OISF#7226
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #11762 +/- ##
==========================================
- Coverage 82.62% 82.54% -0.09%
==========================================
Files 919 919
Lines 248979 248979
==========================================
- Hits 205722 205517 -205
- Misses 43257 43462 +205
Flags with carried forward coverage won't be shown. Click here to find out more. |
Closed
victorjulien
approved these changes
Sep 12, 2024
Closed
|
Merged in #11768, thanks! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the source override in .cargo/config.toml to apply to the suricata-lua-sys crate as well fixing offline builds.
Ticket: #7226
Previous PR: #11624
Changes from last PR: