-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Ci fuzz serde v6.2 #11763
Ci fuzz serde v6.2 #11763
Conversation
for oss-fuzz/cifuzz compatibility As they use an old nightly compiler
because oss-fuzz does not support newer rust nightly and newer serde does not support oss-fuzz old nightly
Probably should squash to one commit that updates the lock and the toml so you don't end up in a state where a commit has the lock and toml out of sync. |
#11741 without toml update still looks simpler/faster/better, just reverting the breaking change |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #11763 +/- ##
==========================================
- Coverage 82.62% 82.54% -0.08%
==========================================
Files 919 919
Lines 248979 248979
==========================================
- Hits 205722 205527 -195
- Misses 43257 43452 +195
Flags with carried forward coverage won't be shown. Click here to find out more. |
We need both to be updated. |
Why so ? |
I've squashed the commits here: #11766 Hopefully makes the FreeBSD builder happy if that's one of the issues. |
While I don't think updating the toml is 100% required, we're pinning it back for a very specific reason, that should be in the toml so this change doesn't get "lost" in a future update to the toml. |
replaced by #11766 |
I hope this change will get "lost" ( because I hope suricata will be able to update to new serde and still have oss-fuzz ) |
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
None
Describe changes:
#11756 with Cargo.toml change in sync with Cargo.lock change
#11741 still looks simpler/faster/better
#11764 is more complete