Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

MySQL protocol parser v1 #11800

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Kotodian
Copy link

@Kotodian Kotodian commented Sep 19, 2024

Make sure these boxes are signed before submitting your Pull Request -- thank you.

Link to ticket: https://redmine.openinfosecfoundation.org/issues/3446

Describe changes:
This is a WIP patchset that implements an application layer for MySQL protocol, many features are not supported.

TBD:
Support Protocol:Handshake V9
Support Protocol:AuthSwitchRequest
Support Protocol:AuthSwitchResponse
Support Protocol:AuthMoreData
Support Protocol:AuthNextFactor
Support Compression
Add documentation
Add SV tests
Fix CI

@victorjulien
Copy link
Member

@glongo I think you mentioned you had some WIP code as well. Care to have a look at this?

Copy link

NOTE: This PR may contain new authors.

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 3.36927% with 717 lines in your changes missing coverage. Please review.

Please upload report for BASE (master@1420c83). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #11800   +/-   ##
=========================================
  Coverage          ?   82.22%           
=========================================
  Files             ?      923           
  Lines             ?   252159           
  Branches          ?        0           
=========================================
  Hits              ?   207349           
  Misses            ?    44810           
  Partials          ?        0           
Flag Coverage Δ
fuzzcorpus 59.64% <0.53%> (?)
livemode 18.48% <3.36%> (?)
pcap 43.43% <3.09%> (?)
suricata-verify 61.08% <3.36%> (?)
unittests 58.90% <0.53%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@jufajardini jufajardini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the TBD list ;)

  • update etc/schema.json
  • update commit messages to contain Ticket number in the commit body (Task #3446 )
  • update your git author to follow the format FirstName LastName

:P

nit: in the commit messages, you can remove the rust/ portion

@glongo
Copy link
Contributor

glongo commented Sep 19, 2024

@glongo I think you mentioned you had some WIP code as well. Care to have a look at this?

Yes sure.

@Kotodian Kotodian force-pushed the dev-3346-mysql-proto-v1 branch 2 times, most recently from 5083bc9 to 3fe510b Compare September 20, 2024 01:17
@Kotodian
Copy link
Author

For the TBD list ;)

* update etc/schema.json

* update commit messages to contain Ticket number in the commit body (`Task #3446` )

* update your git author to follow the format `FirstName LastName`

:P

nit: in the commit messages, you can remove the rust/ portion

I have fixed, please check again, thx.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants