Decouple stream bypass from TLS encrypted bypass v3 #11801
+85
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Decouple app.protocols.tls.encryption-handling and stream.bypass. There's no apparent reason why encrypted TLS bypass traffic should depend on stream bypass, as these are unrelated features. Ticket: 6788
lukashino
requested review from
catenacyber,
jufajardini,
victorjulien and
a team
as code owners
3 tasks
|
NOTE: This PR may contain new authors. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11801 +/- ##
=========================================
Coverage ? 82.59%
=========================================
Files ? 919
Lines ? 249030
Branches ? 0
=========================================
Hits ? 205675
Misses ? 43355
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Awesome, thank you for picking this up. |
|
WARNING:
Pipeline 22744 |
|
I believe this is due to SSH connections not being bypassed, if the config has stream bypass configured then SSH encryption handling setting would also need to be changed to |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on #10464
Redmine ticket: https://redmine.openinfosecfoundation.org/issues/6788
Describe changes:
encryption-handlingallowing to choose whether to continue inspection on SSH once it turns encryptedSV_BRANCH=OISF/suricata-verify#2047