stream: improve 3whs completed by ACK with data #11805
Conversation
If the ACK completing the 3whs, the stream engine will transition to "established". However, the packet itself will not be tagged as "established". This will only happen for the next packet after the 3whs, so that `flow:established` only matches after the 3whs. It is also possible that the ACK completing the 3whs was lost. Since the ACK packets themself are not acknoledged, there will be no retransmission of them. Instead, the next packet can have the ACK flag as well as data. This case was mishandled in a suble way. The stream engine state transition was done correctly, as well as the data handling and app-layer updates. However, the packet itself was not tagged as "established", which meant that `flow:established` would not yet match. This patch detects this case and tags the packet as established if ACK with data is received that completes the 3whs. Bug: OISF#7264.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #11805 +/- ##
=========================================
Coverage ? 82.59%
=========================================
Files ? 919
Lines ? 249009
Branches ? 0
=========================================
Hits ? 205664
Misses ? 43345
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 22761 |
There was a problem hiding this comment.
Thanks for the work.
Mostly ok, the commit message can be improved a bit I think.
CI : ok
Commits segmentation : ok
Commit messages : 🟠 typos acknoledged suble, also If the ACK completing the 3whs does not seem right English syntax to me...
Git ID set : ok
CLA : you already contributed
Doc update : not needed
Redmine ticket : 🟡 should it not be back ported ?
Rustfmt : no rust
Tests : nice, thanks
Dependencies added: none
Code : good
not sure, but, I think it should also be s/ |
|
replaced by #11821 |
If the ACK completing the 3whs, the stream engine will transition to "established". However, the packet itself will not be tagged as "established". This will only happen for the next packet after the 3whs, so that
flow:establishedonly matches after the 3whs.It is also possible that the ACK completing the 3whs was lost. Since the ACK packets themself are not acknoledged, there will be no retransmission of them. Instead, the next packet can have the ACK flag as well as data.
This case was mishandled in a suble way. The stream engine state transition was done correctly, as well as the data handling and app-layer updates. However, the packet itself was not tagged as "established", which meant that
flow:establishedwould not yet match.This patch detects this case and tags the packet as established if ACK with data is received that completes the 3whs.
Bug: #7264.
SV_BRANCH=OISF/suricata-verify#2051