next/582/20240922/v1 #11809
Merged
next/582/20240922/v1 #11809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: 7126
This commit abandons the use of StringParseUint32 which generates an
error message of there are non-numeric characters.
The SMTP parser had used this function on the packet path; this commit
uses strtoul instead.
An example of the content causing the error message to be emitted:
3460 LAST
Per the notes for strtoul, since 0 or ULONG_MAX is a legitimate return value, errno must be cleared before the call so an error can be checked after the call by testing errno. Issue: 7126
According to RFC 3261, a single header can be repeated one or more times, and its name can also be specified using the 'compact form.' This patch updates the hashmap used for storing headers to accommodate multiple values instead of just one. Additionally, if a header name is defined in the compact form, it is expanded into its long form (i.e., the standard name). This conversion simplifies the logic for matching a given header and ensures 1:1 parity with keywords. Ticket OISF#6374
To match on response SIP headers, those headers must be stored. Ticket OISF#6374
This adds a sticky (multi) buffer to match the "From" header field in both requests and responses. Ticket OISF#6374
This adds a sticky (multi) buffer to match the 'To' header field in both requests and responses. Ticket OISF#6374
This adds a sticky (multi) buffer to match the "Via" header field in both requests and responses. Ticket OISF#6374
This adds a sticky (multi) buffer to match the "User-Agent" header field in both requests and responses. Ticket OISF#6374
This adds a sticky (multi) buffer to match the "Content-Type" header field in both requests and responses. Ticket OISF#6374
This adds a sticky (multi) buffer to match the "Content-Length" header field in both requests and responses. Ticket OISF#6374
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11809 +/- ##
==========================================
- Coverage 82.59% 82.58% -0.02%
==========================================
Files 919 914 -5
Lines 249091 249500 +409
==========================================
+ Hits 205738 206045 +307
- Misses 43353 43455 +102
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
WARNING:
Pipeline 22763 |
catenacyber
approved these changes
Sep 23, 2024
There was a problem hiding this comment.
CI is green
SV branch is correct
Consistent with the approved PRs
nit: 6b7098d will improve on rust style
This was referenced Sep 23, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Staging:
SV_BRANCH=OISF/suricata-verify#2053