Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

D4.1 fixes #63

Merged
merged 7 commits into from
Oct 11, 2024
Merged

D4.1 fixes #63

merged 7 commits into from
Oct 11, 2024

Conversation

schivmeister
Copy link
Collaborator

@schivmeister schivmeister commented Sep 27, 2024 •
edited
Loading

As per feedback for D4.1 CAN packages, rc.7.

@schivmeister
Convert CAN Procedure RML file to UNIX line endings
c4b4609
@schivmeister
Fix gh-56 multiple values for MonetaryValue
8bf64a6 
The path reference in the subject template was wrong.

Tested with v1.8 notice 191534-2024.xml (Official Journal publication
2024-OJS065-00191534) as downloaded from
https://ted.europa.eu/en/notice/191534-2024/xml.

Closes gh-56.
@schivmeister
Fix gh-59 missing OPP-090-Procedure NoticeDocumentReference
61ca087 
Tested with v1.7 notice 191536-2024.xml (Official Journal publication
2024-OJS065-00191536) as downloaded from
https://ted.europa.eu/en/notice/191536-2024/xml.

Closes gh-59.
cristianvasquez
cristianvasquez approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@cristianvasquez cristianvasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me!

Base automatically changed from feature/can-changes-d2.2-d4.1 to develop October 1, 2024 17:07
@schivmeister
Add a CAN sample test file for testing certain CAN roles
65c736a 
PaymentExecutor (PayerParty) and BudgetProvider (FinancingParty) are not
present among SDK examples.
@schivmeister
Add announcesRole for BudgetProvider and PaymentExecutor
b519283 
A ResultNotice can announce these roles (ND-FinancingParty and
ND-PayerParty).
@schivmeister
Seed CAN roles' hashes to prevent unwanted redundancy
6bb249b 
This technique to hash the IRI trailer with the ID of the referenced
Organization along with any schemeName, first used in the OPT-301-* role
instantations, prevents recurrence of a role for different lots, in this
case PaymentExecutor and BudgetProvider.
@schivmeister
Copy link
Collaborator Author

schivmeister commented Oct 2, 2024 •
edited
Loading

Force-pushed to include change tracking of a sample data file for some additional fixes. Please reset --hard this branch against its origin if you had checked out code before this comment.

@schivmeister
Add output assets for CAN MS D4.1 revision
e2db2a6 
- refersToProcedure gh-59
- MonetaryValue instantiation gh-56
- hasLegalBasis gh-52 (port from CN D2.2 second revision)
- announcesRole PaymentExecutor / BudgetProvider (sample data added)
csnyulas
csnyulas approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@csnyulas csnyulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All is good!

@csnyulas csnyulas merged commit 5628eea into develop Oct 11, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@cristianvasquez cristianvasquez cristianvasquez approved these changes

@csnyulas csnyulas csnyulas approved these changes

Assignees

@cristianvasquez cristianvasquez

@csnyulas csnyulas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schivmeister @cristianvasquez @csnyulas