All fixes and improvements, including language maps #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contract-[hasLotReference]->Lot Resolves the unwanted state of a Contract linking to Lots referenced across all LotAwardOutcomes. The Contract should link to only the Lot referenced in the respective LotAwardOutcome, as per OPT-315-LotResult.
Tender-[specifiesSubcontractors]->Subcontractor The Subcontractor was linked to only one (or the first) Tender due to an incorrect template vs. iterator and joinCondition issue. This resolves it such that all Tenders citing the Tenderer associated with the Subcontractor are the ones to which the Subcontractor is linked. A modified version of the notice 2024-OJS072-00215550 is used to test this, as it would expose the underlying issue if the original incorrect mapping were to exist. Co-authored-by: csnyulas <csongor.nyulas@gmail.com>
LotGroupAwardInformation-[describesLotGroup]->LotGroup Partial fix for linking LotGroup mapping for GroupFrameworkAgreement.
hasCurrency mappings for: - BT-161-NoticeResult - BT-118-NoticeResult - BT-1118-NoticeResult
To be consistent with the technique used to hash the IRI trailer of other roles, first used in the OPT-301-* mappings to prevent recurrence of a role for different lots. Even if such a relationship doesn't exist now, it could impact other situations in the future for the Subcontractor.
CN has only one multilingual example, and CAN has no such examples. Co-authored-by: schivmeister <rashif.rahman@meaningfy.ws>
Extract languageMaps into their own TriplesMaps as RML is "underspecified" for multi-valued properties, leading to odd behaviour in beyond-basic use cases (in this case language code transformation via CSV lookup function). Effectively fixes gh-66 but implements an unintuitive mapping approach (predicate at its own iterator). See also RMLio/rmlmapper-java#235. Affects: - ChangeInformation - ContactPoint - Lot - LotGroup - Organization - Procedure - BT-75-Lot versioned, with fix for version range and dupe conflict - BT-772-Lot versioned ChangeInformation tested with 673305-2023.xml. Many of the Lot fields could not be tested due to unavailability of data (not easily searchable or requirements expressible through currently available means). The change for BT-75-Lot fixes the situation where there was a redundant 1.4+ mapping in the common Lot RML file, and a mistaken version annotation for 1.3-1.3 (being marked as min 1.4). Because later versions are less restrictive, this cannot easily be caught, but was otherwise wrong (the common would override). Additionally, remove some conflicting dupe references in Procedure: - BT-01(d)-Procedure - BT-1351-Procedure This may or may not have led to undefined behaviour in the mapping (there were no change in outputs so hopefully this had no impact).
Extract languageMaps into their own TriplesMaps as RML is "underspecified" for multi-valued properties, leading to odd behaviour in beyond-basic use cases (in this case language code transformation via CSV lookup function). Effectively fixes gh-66 but implements an unintuitive mapping approach (predicate at its own iterator). See also RMLio/rmlmapper-java#235. Affects: - Contract - Procedure CAN - BT-554-Tender versioned
D4.1 improvements
Refactored languageMaps, CN and CAN
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.