Support filtering by formation/polygon when calculating statistics #12086
+455
−82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonjenssen
force-pushed
the
ensemble_formations
branch
2 times, most recently
from
6050b0e to
4c0f465
Compare
jonjenssen
changed the title
jonjenssen
changed the title
Handle formation names for reload of project.
jonjenssen
force-pushed
the
ensemble_formations
branch
from
4c08792 to
c47b10b
Compare
magnesj
requested changes
Jan 28, 2025
|
|
||
| class RimFormationNames; | ||
|
|
||
| class RimFormationTools |
There was a problem hiding this comment.
Consider using namespace RimFormationTools instead of class RimFormationTools
| { | ||
| if ( !polygonCollection->allPolygons().empty() ) | ||
| { | ||
| auto polyGrp = uiOrdering.addNewGroup( "Polygon Selection" ); |
There was a problem hiding this comment.
Add skipRemainingFields at end of this function to make sure the polygon selection is not visibible if no polygons are available.
| { | ||
| cvf::Vec3d pos3D( point ); | ||
|
|
||
| bool bIncludesCell = false; |
There was a problem hiding this comment.
Consider bool includesCell = false;
| RimEclipseCase::initAfterRead(); | ||
|
|
||
| // handle special formations for ensembles | ||
| auto ensemble = firstAncestorOrThisOfType<RimEclipseCaseEnsemble>(); |
There was a problem hiding this comment.
Consider
if ( auto ensemble = firstAncestorOrThisOfType<RimEclipseCaseEnsemble>() )
| //-------------------------------------------------------------------------------------------------- | ||
| std::vector<std::vector<cvf::Vec3d>> RimStatisticsContourMap::selectedPolygons() | ||
| { | ||
| std::vector<std::vector<cvf::Vec3d>> allLines; |
There was a problem hiding this comment.
This is a lot of text std::vector<std::vector<cvf::Vec3d>
Consider adding a using statement in RigPolyLinesData.
Suggested naming
using PolyLineCoords = std::vector<std::vector<cvf::Vec3d>>;
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12057
Closes #12066