Skip to content

Code clean-up #168

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 3 commits into from
May 28, 2025
Merged

Code clean-up #168

merged 3 commits into from
May 28, 2025

Conversation

rimi-itk
Copy link
Collaborator

@rimi-itk rimi-itk commented Apr 29, 2025

Cleans up code.

  • Updates GitHub Actions workflow
  • Defines and applies coding standards for Markdown
  • Minor clean-ups in PHP code

@rimi-itk rimi-itk force-pushed the feature/code-cleanup branch 3 times, most recently from a4dc89e to 43944cc Compare April 29, 2025 11:11
@rimi-itk rimi-itk changed the title Cleaned up code Code clean-up Apr 29, 2025
@rimi-itk rimi-itk force-pushed the feature/code-cleanup branch 3 times, most recently from b849e83 to efa9729 Compare April 29, 2025 11:45
@rimi-itk rimi-itk force-pushed the feature/code-cleanup branch from efa9729 to a538d3d Compare April 29, 2025 11:46
@rimi-itk rimi-itk marked this pull request as ready for review April 29, 2025 11:49
@rimi-itk rimi-itk requested review from stankut and jekuaitk and removed request for stankut April 29, 2025 11:50
Co-authored-by: Jeppe Kuhlmann Andersen <78410897+jekuaitk@users.noreply.github.com>
@rimi-itk rimi-itk force-pushed the feature/code-cleanup branch from 2870526 to c5d6763 Compare April 30, 2025 10:13
@rimi-itk rimi-itk requested review from jekuaitk and stankut April 30, 2025 10:17
Comment on lines +131 to +138
> [!TIP]
> If the `composer install` commands fails with
>
> > Unable to install module simplesamlphp/simplesamlphp-assets-base, package name must be on the form "VENDOR/simplesamlphp-module-MODULENAME".
>
> you can remove the `vendor` folder and rerun the `composer install` command (cf.
> <https://www.drupal.org/project/simplesamlphp_auth/issues/3350773>).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@stankut
Copy link
Collaborator

stankut commented May 28, 2025

@rimi-itk thanks for separate commits and a cleanup!
it was very clean and easy to understand what the changes are about

@rimi-itk rimi-itk merged commit 5012576 into OS2Forms:develop May 28, 2025
8 checks passed
@rimi-itk rimi-itk deleted the feature/code-cleanup branch May 28, 2025 12:47
@jekuaitk jekuaitk mentioned this pull request Jun 3, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants