Skip to content

Handle anonymous users in notifications and flow tasks #56

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Conversation

rimi-itk
Copy link
Collaborator

@rimi-itk rimi-itk commented Sep 14, 2023

  • Implements hook_maestro_zero_user_notification and adds Maestro notification handler for sending notifications via email or digital post to anonymous users
  • Cleans up MaestroWebformInheritTask by removing code that creates submissions before a form is displayed and uses hook_webform_submission_form_alter to pre-fill controls instead.

See changes in README.md for more details.

Important: As of now, this update has a “soft dependency” on https://github.com/itk-dev/os2forms_digital_post, i.e. we can run without the os2forms_digital_post module being installed but then only send notifications via email. Moving https://github.com/itk-dev/os2forms_digital_post into https://github.com/OS2Forms/os2forms is in the works, but some details and challenges on how to actually do it have yet to be sorted out.

@rimi-itk rimi-itk changed the title Handled anonymous users in notifications and flow tasks Handle anonymous users in notifications and flow tasks Sep 14, 2023
@rimi-itk rimi-itk force-pushed the feature/maestro-anonymous-notifications-and-flows branch from 6aa01ec to f45c9f1 Compare September 14, 2023 12:43
@rimi-itk rimi-itk force-pushed the feature/maestro-anonymous-notifications-and-flows branch 2 times, most recently from 0f3a763 to 563c5db Compare September 25, 2023 11:42
@rimi-itk rimi-itk force-pushed the feature/maestro-anonymous-notifications-and-flows branch from 563c5db to bda0f51 Compare September 25, 2023 11:52
@rimi-itk rimi-itk force-pushed the feature/maestro-anonymous-notifications-and-flows branch from bda0f51 to 6f0fa15 Compare September 25, 2023 12:08
@rimi-itk rimi-itk requested a review from stankut September 28, 2023 14:44
@rimi-itk rimi-itk requested a review from stankut September 29, 2023 11:32
@rimi-itk rimi-itk force-pushed the feature/maestro-anonymous-notifications-and-flows branch from 81afd5b to 1473dd6 Compare September 29, 2023 11:38
@stankut
Copy link
Collaborator

stankut commented Sep 29, 2023

thanks for the changes @rimi-itk
i have now approve the PR

@stankut stankut merged commit 14deaec into OS2Forms:develop Sep 29, 2023
@rimi-itk rimi-itk mentioned this pull request Oct 3, 2023
@rimi-itk rimi-itk deleted the feature/maestro-anonymous-notifications-and-flows branch October 3, 2023 11:26
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants