-
Notifications
You must be signed in to change notification settings - Fork 8
Codereview focus update #9
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
base: master
Are you sure you want to change the base?
Conversation
Adding section with codereview tasks.
@@ -76,7 +76,7 @@ For new repositories it was decided to switch back to github, | |||
composer way to for branch names. | |||
|
|||
<a name="code-review"></a> | |||
## Code review | |||
## Code review proces |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: “proces” should be “process”
@@ -93,6 +93,13 @@ NOTE: There are preconditions that have to be met before accepting a pull reques | |||
- All discussion have to be resolved | |||
- Pull request should have green Travis CI build status. | |||
|
|||
##Code review tasks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add space after ##
like done elsewhere in this file.
Giving codereview to other developers code should cover | ||
1. The use of [Code of conduct](docs#coc) | ||
2. The following of the [Testing standards](docs#testing-and-ci) | ||
3. That kode is handling successes and errors, can not end in loops and other logical |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: “kode” should be “code”. Something is missing after “other logical”.
1. The use of [Code of conduct](docs#coc) | ||
2. The following of the [Testing standards](docs#testing-and-ci) | ||
3. That kode is handling successes and errors, can not end in loops and other logical |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use consistent spacing after list numbers (cf. https://www.markdownguide.org/basic-syntax/#ordered-lists).
Adding section with codereview tasks.