Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Audit dependencies and fix client build #212

Merged
merged 1 commit into from
Apr 26, 2024
Merged

Audit dependencies and fix client build #212

merged 1 commit into from
Apr 26, 2024

Conversation

nilsstreedain
Copy link
Member

Pull Request Template

Description

General cleanup for installation. Audited npm dependencies to reduce vulnerabilities and improve installation experience. Fixed react build warnings from legacy CSS implementations.

Fixes #39

Checklist:

Before you submit your Pull Request, please make sure you have completed the following tasks:

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.
  • I have tagged my PR with the appropriate label(s).

@nilsstreedain nilsstreedain added bug Something isn't working dependencies Pull requests that update a dependency file security Investigating or resolving a potential security issue labels Apr 26, 2024
@nilsstreedain nilsstreedain self-assigned this Apr 26, 2024
@nilsstreedain nilsstreedain requested review from a team April 26, 2024 03:17
Copy link
Contributor

@Durbin-Elijah Durbin-Elijah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this. I tested on my machine and didn't see any issues.
(Did npm audit and npm install before running on both client and server to be sure.)

@nilsstreedain nilsstreedain added this pull request to the merge queue Apr 26, 2024
Merged via the queue into dev with commit d7ab620 Apr 26, 2024
2 checks passed
@nilsstreedain nilsstreedain deleted the fix-build branch April 26, 2024 05:26
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file security Investigating or resolving a potential security issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Frontend Dependancies
2 participants