Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Redesign Home #221

Merged
merged 17 commits into from
May 20, 2024
Merged

Redesign Home #221

merged 17 commits into from
May 20, 2024

Conversation

nilsstreedain
Copy link
Member

@nilsstreedain nilsstreedain commented May 11, 2024

Redesign Home

Screenshots

image

Description

@Durbin-Elijah's structural changes for the homepage redesign (not the final version to be done by @nilsstreedain). The old homepage has been removed and replaced by a placeholder, early version of the new one. In a later PR, this page will be cleaned up and refined by @nilsstreedain for production.

Additional Information

Checklist:

Before you submit your Pull Request, please make sure you have completed the following tasks:

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.
  • I have tagged my PR with the appropriate label(s).

Durbin-Elijah and others added 15 commits May 10, 2024 17:31
…s page, including nav buttons at the top of all pages
* updated navBar and cleaned related code

* redesigned login page TODO: comments

* added comments that seem neccesary

* Changed routing to always allow logged in users to get back to courses page, including nav buttons at the top of all pages

* added 1 image from /public

* Added UI images from client/public/

* Redid # page

* updated # navbar and left side text

* enabled navigation between home, #, and login, set up # to handle isTeacher

* changes app.js to be consistent with current version after changes

* added arrow-left-solid.svg
@nilsstreedain nilsstreedain force-pushed the redesign-home branch 2 times, most recently from 9610b26 to 8ff2f67 Compare May 11, 2024 02:06
@nilsstreedain nilsstreedain marked this pull request as ready for review May 13, 2024 22:57
@nilsstreedain nilsstreedain requested a review from a team May 13, 2024 22:57
@nilsstreedain nilsstreedain added development Updates and modifications to development/deployment tools labels May 14, 2024
@nilsstreedain nilsstreedain changed the title DO NOT MERGE: Redesign home Redesign Home May 14, 2024
@nilsstreedain nilsstreedain enabled auto-merge May 14, 2024 00:04
@nilsstreedain nilsstreedain requested review from a team and removed request for a team May 16, 2024 04:25
@Justin-Fernbaugh
Copy link
Member

Just to re-iterate: Seems like the third infobox on the right side doesn't currently contain any data.

@nilsstreedain nilsstreedain requested review from a team and removed request for a team May 16, 2024 05:26
@Durbin-Elijah
Copy link
Contributor

Looks good, the final info box should be filled in later, works as a template for now to make further style changes

@nilsstreedain nilsstreedain requested a review from a team May 16, 2024 05:39
Copy link
Contributor

@Durbin-Elijah Durbin-Elijah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Above comment, I'm approving based on other team members saying there were no issues, since many of the changes are mine

@nilsstreedain nilsstreedain added this pull request to the merge queue May 20, 2024
Merged via the queue into dev with commit 0a7d765 May 20, 2024
2 checks passed
@nilsstreedain nilsstreedain deleted the redesign-home branch May 20, 2024 22:30
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
development Updates and modifications to development/deployment tools enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants