Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Redesign Cleanup #234

Merged
merged 17 commits into from
May 26, 2024
Merged

Redesign Cleanup #234

merged 17 commits into from
May 26, 2024

Conversation

nilsstreedain
Copy link
Member

Redesign Cleanup

Screenshots

SCR-20240526-dobz SCR-20240526-dohl SCR-20240526-doek image

Description

This PR primarily consists of cleanup and refinement of changes made by @Durbin-Elijah. Some additional changes have also been added, see below:

  • Completed redesign and consolidated styling for Home and Courses pages
  • Redesigned PageButton pop-up.
  • Added favicon
  • Refactored most of index.css into individual component style sheets
  • Fixed broken logo bug
  • Redesign navbar (top navbar and teacher sidebar)
  • Fix student crash bug upon empty section (still need to address missing lectures)
  • Fix broken student course links
  • Update roster list view
  • Update react bootstrap button styling to current color scheme (can't seem to change the default color of :active or :focus?)

Fixes #203

Checklist:

Before you submit your Pull Request, please make sure you have completed the following tasks:

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.
  • I have tagged my PR with the appropriate label(s).

@nilsstreedain nilsstreedain self-assigned this May 26, 2024
@nilsstreedain nilsstreedain added the enhancement New feature or request label May 26, 2024
@nilsstreedain nilsstreedain marked this pull request as ready for review May 26, 2024 10:16
@nilsstreedain nilsstreedain requested a review from a team May 26, 2024 10:16
Copy link
Contributor

@Durbin-Elijah Durbin-Elijah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super clean! Everything looks super clean and navigates very well.
I only found 1 super tiny issue with the create course button overlapping when scrolling.

image

I think it should be a super simple fix and then it should be all good to merge.

@Durbin-Elijah
Copy link
Contributor

image
I actually noticed 1 other thing I think the container for these elements need some margin at the bottom

@nilsstreedain
Copy link
Member Author

Super clean! Everything looks super clean and navigates very well. I only found 1 super tiny issue with the create course button overlapping when scrolling.

I think it should be a super simple fix and then it should be all good to merge.

Ahh, for some reason it renders differently on chrome than safari, fixed it with z-index.

@Durbin-Elijah
Copy link
Contributor

Durbin-Elijah commented May 26, 2024

Super clean! Everything looks super clean and navigates very well. I only found 1 super tiny issue with the create course button overlapping when scrolling.
I think it should be a super simple fix and then it should be all good to merge.

Ahh, for some reason it renders differently on chrome than safari, fixed it with z-index.

Ahh it works a lot better now in that way, except I am now unable to click the button haha. Definitely seems like some weird interaction differences between the browsers with z-index, as I can see the landing header is covering it up when inspecting.

image

EDIT: It's not the header blocking it, since it's part of the header, its the courses div.

@nilsstreedain
Copy link
Member Author

EDIT: It's not the header blocking it, since it's part of the header, its the courses div.

Oh man XD! Try now

Copy link
Contributor

@Durbin-Elijah Durbin-Elijah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, works great and look amazing, the website will be so visually appealing for the demo and expo with all these changes.

@nilsstreedain nilsstreedain added this pull request to the merge queue May 26, 2024
Merged via the queue into dev with commit 0c6f4a5 May 26, 2024
2 checks passed
@nilsstreedain nilsstreedain deleted the redesign-cleanup branch May 26, 2024 21:21
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navbar flex centering
2 participants