socket.io integration to lectures #236
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilsstreedain
requested changes
Jun 1, 2024
There was a problem hiding this comment.
After installing socket.io-client in /client/package.json, I'm still having issues running the site locally. It occasionally appears to load infinitely, however I've gotten the following error to display a few times:
Uncaught runtime errors:
×
ERROR
undefined is not an object (evaluating 'e.response.status')
@http://localhost:3000/static/js/bundle.js:10493:19
I've tried fully wiping the repo and any docker volumes from my machine but the problem persisted.
| import Notice from '../components/Notice' | ||
| import { Button, Card } from "react-bootstrap" | ||
| import useLectureQuestions from "../hooks/useLectureQuestions"; | ||
| import useCourse from "../hooks/useCourse"; | ||
| import useLectures from '../hooks/useLectures'; | ||
| import QuestionCard from '../components/QuestionCard'; | ||
|
|
||
| import io from 'socket.io-client'; |
There was a problem hiding this comment.
socket.io-client appears to be imported, but is not added to the client package.json causing compilation to fail.
|
Architecture design has changed, and this implementation of socket.io for features will no longer be valid. Closing PR. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Socket.io integration to lectures:
To see changes in the server as a student:
log in as a student, and connect to any lecture by clicking "view lecture". The server will log out that a user has connected to the lecture.
To see changes as a teacher:
log in as a teacher, click "view sessions", click "lectures" in the menu, then click "edit lecture". The server will log out that a teacher had connected. (For future teams might be helpful to change this button name to connect to lecture, etc.)