-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Merge rumseyn/update-dependencies #252
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8srumsey
added
dependencies
Pull requests that update a dependency file
security
Investigating or resolving a potential security issue
labels
Oct 27, 2024
n8srumsey
commented
Nov 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previously received verbal approval, waited for over 2 weeks for official code review, so pushing this through now
SonnySideUp37
approved these changes
Nov 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
enjiwood
approved these changes
Nov 5, 2024
sgoober
approved these changes
Nov 5, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
dependencies
Pull requests that update a dependency file
security
Investigating or resolving a potential security issue
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Screenshots
N/A
Description
These changes migrates the project from the now deprecated
create-react-app
tovite
as well as resolves node package security vulnerabilities from old dependency versions. With this change, I recommend you all runnpm install
in the root directory to install the new npm dependencies. Additionally, I recommend you to rundocker compose build
in theserver/
directory to update the cached container build.Additionally, for the
client/
code, the packagevitest
was added and configured to run integration and unit tests, with a placeholder test already written. This PR does not aim to implement front end testing; it was only setting up the dependencies for it to be run in the first place.Fixes # N/A - No issue
Additional Information
The necessary changes to documentation have not been made. This is largely due to the priority of providing a stable solution for the project dependencies for group members to initiate work.
Checklist:
Before you submit your Pull Request, please make sure you have completed the following tasks: