Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merge rumseyn/update-dependencies #252

Merged
merged 3 commits into from
Nov 5, 2024
Merged

Conversation

n8srumsey
Copy link
Contributor

@n8srumsey n8srumsey commented Oct 27, 2024

Pull Request Template

Screenshots

N/A

Description

These changes migrates the project from the now deprecated create-react-app to vite as well as resolves node package security vulnerabilities from old dependency versions. With this change, I recommend you all run npm install in the root directory to install the new npm dependencies. Additionally, I recommend you to run docker compose build in the server/ directory to update the cached container build.

Additionally, for the client/ code, the package vitest was added and configured to run integration and unit tests, with a placeholder test already written. This PR does not aim to implement front end testing; it was only setting up the dependencies for it to be run in the first place.

Fixes # N/A - No issue

Additional Information

The necessary changes to documentation have not been made. This is largely due to the priority of providing a stable solution for the project dependencies for group members to initiate work.

Checklist:

Before you submit your Pull Request, please make sure you have completed the following tasks:

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.
  • I have tagged my PR with the appropriate label(s).

@n8srumsey n8srumsey added dependencies Pull requests that update a dependency file security Investigating or resolving a potential security issue labels Oct 27, 2024
@n8srumsey n8srumsey requested review from a team October 27, 2024 01:50
@n8srumsey n8srumsey requested a review from a team as a code owner October 27, 2024 01:50
@baumannevan baumannevan enabled auto-merge November 4, 2024 01:06
Copy link
Contributor Author

@n8srumsey n8srumsey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously received verbal approval, waited for over 2 weeks for official code review, so pushing this through now

Copy link

@SonnySideUp37 SonnySideUp37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@n8srumsey n8srumsey closed this Nov 5, 2024
auto-merge was automatically disabled November 5, 2024 04:44

Pull request was closed

@n8srumsey n8srumsey reopened this Nov 5, 2024
@n8srumsey n8srumsey closed this Nov 5, 2024
@n8srumsey n8srumsey reopened this Nov 5, 2024
@n8srumsey n8srumsey added this pull request to the merge queue Nov 5, 2024
Merged via the queue into main with commit 78d669c Nov 5, 2024
2 checks passed
@n8srumsey n8srumsey deleted the rumseyn/update-dependencies branch November 5, 2024 04:54
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
dependencies Pull requests that update a dependency file security Investigating or resolving a potential security issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants