Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Unable to pass env vars to set mongodb uri #173

Closed
bizob2828 opened this issue Sep 26, 2019 · 2 comments
Closed

Unable to pass env vars to set mongodb uri #173

bizob2828 opened this issue Sep 26, 2019 · 2 comments
Assignees
@ckarande @UlisesGascon
Labels
enhancement infrastructure js
Milestone
v1.5

Comments

@bizob2828
Copy link
Contributor

We use NodeGoat to test some of our code and we programmatically pass in mongodb uri via MONGODB_URI env var. This worked just fine until #147 was merged. The changed in https://github.com/OWASP/NodeGoat/pull/147/files#diff-5ad5fa7320dd1d0531493bee405d385b made the 2 env vars useless.
@bizob2828 bizob2828 mentioned this issue Sep 26, 2019
Merged
@ckarande
Copy link
Member

ckarande commented Sep 28, 2019 •
edited
Loading

@bizob2828 Just noticed your PR. Thanks for updating about the issue and making the PR. 👍

It looks good to me and I have approved it. @UlisesGascon can you please have a look at the PR and merge if you see no issues running cypress tests with this change.

@UlisesGascon UlisesGascon added this to the v1.5 milestone Sep 30, 2019
@UlisesGascon
Copy link
Collaborator

Closed in #174

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@ckarande ckarande

@UlisesGascon UlisesGascon

Labels
enhancement infrastructure js
Projects
None yet
Milestone
v1.5
Development

No branches or pull requests
3 participants
@ckarande @bizob2828 @UlisesGascon