Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Feature: CI with Travis #147

Merged
merged 8 commits into from
Aug 3, 2019
Merged

Feature: CI with Travis #147

merged 8 commits into from
Aug 3, 2019

Conversation

UlisesGascon
Copy link
Collaborator

@UlisesGascon UlisesGascon commented Jul 31, 2019

Context #144

Changelog

  • Added Travis logic in .travis.yml
  • Updated shebang in Mongodb seed script
  • Added several tasks in package.json
  • Improved configuration for mongodb url
  • Improved database cleanup task in cypress

@UlisesGascon
Copy link
Collaborator Author

UlisesGascon commented Jul 31, 2019

OMG!! We made it! Green light in 7 min 56 sec. 🎉 🎉

Note: There is a lot of optimization pending :trollface:

@ckarande
Copy link
Member

ckarande commented Aug 1, 2019

Woo hoo! Great to see the travis integrated and all green tests ending with "The command "npm run test:ci" exited with 0." Great work, I am super excited👍.
Once you think it is ready to merge, I will run assist in validating that tests work in local environment. Thanks!

@UlisesGascon
Copy link
Collaborator Author

UlisesGascon commented Aug 2, 2019

Well, last changes made. It's time to review and merge @ckarande. 🎉

I will generate few issues after this merge to let other interested developers join to our refactor adventure (I will prepare an Open Source hackathon session soon) 🌮

If you want you can provide access to manage issues, so I can create labels and assign them to roadmaps, etc.. 😉

@ckarande ckarande merged commit 9e35cae into OWASP:master Aug 3, 2019
@ckarande
Copy link
Member

ckarande commented Aug 3, 2019

Great work! Thank you so much for your awesome contributions. I think we can close issue#144 now?

I will create a release with the codebase so far, so that we can start adding new enhancements. Let's collaborate on planning what fixes to cover and order of those before the hackathon sessions. I will share some thoughts on it as a starting point. Also, I'd be happy to grant collaborator rights to you for the project. Thanks again for all your contributions.

@UlisesGascon
Copy link
Collaborator Author

UlisesGascon commented Aug 4, 2019

Awesome! I will rise an issue soon with all the ideas and a possible roadmap to discuss (priorities, releases, etc..)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants