Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: 🍰 Save Categories In Frontend #5284

Merged
merged 21 commits into from
Sep 12, 2022
Merged

Conversation

Mogge
Copy link
Contributor

@Mogge Mogge commented Sep 6, 2022

🍰 Pull Request

Provide a button in category filter menu, to save the current selected categories.

Copy link
Member

@Tirokk Tirokk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general it does not working as I would expect:

  • After a reload of the page it loses all themes saved somehow.
  • After login I don't have the themes set like I save for this user. Often I have the ones set which I had as I logged out with another user with different themes saved.

I have a little suggestion for the locales …

PS: In the database it is difficult to see which categories are selected on testing … 😅 Which is not related …

Mogge and others added 3 commits September 8, 2022 15:17
Co-authored-by: Wolfgang Huß <wolle.huss@pjannto.com>
Co-authored-by: Wolfgang Huß <wolle.huss@pjannto.com>
Copy link
Member

@Tirokk Tirokk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool @Mogge 👍🏼😍

Now it works like expected !!! 🚀🚀💫💫

If you like create an issue for the reload problem and we have a look later on …

@Tirokk Tirokk changed the title feat: Save Categories in Frontend feat: 🍰Save Categories In Frontend Sep 10, 2022
@Tirokk Tirokk changed the title feat: 🍰Save Categories In Frontend feat: 🍰 Save Categories In Frontend Sep 10, 2022
@Mogge Mogge merged commit 922ca2d into master Sep 12, 2022
@Mogge Mogge deleted the save-categories-in-frontend branch September 12, 2022 13:08
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants