feat: 🍰 Refine Group Creation And Group Edit #5418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogerly
changed the base branch from
master
to
5344-add-group-members-management
Tirokk
changed the title
Tirokk
reviewed
Sep 29, 2022
…ithub.com/Ocelot-Social-Community/Ocelot-Social into 5397-Refine-Group-Creation-And-Group-Edit
|
|
Base automatically changed from
5344-add-group-members-management
to
5059-epic-groups
September 30, 2022 06:13
Tirokk
requested changes
Sep 30, 2022
Tirokk
requested changes
Oct 2, 2022
There was a problem hiding this comment.
Cool that you have found out the validation problem with the selects. 😄
I would change some things …
The error message name must be between 3 and 50 characters is not translated.
Can we get rid of this grey strokes under the select if all is okay?
Or put 1 / 1 in the grey chip?
We have different space between several things:
Co-authored-by: Wolfgang Huß <wolle.huss@pjannto.com>
…ithub.com/Ocelot-Social-Community/Ocelot-Social into 5397-Refine-Group-Creation-And-Group-Edit
ogerly
changed the title
|
@Tirokk i put another ds-space in the form when editing group data. there was no clean space between slug and groupType. |
18 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍰 Pull Request
Issues
tip-tap editor
clear location input
localisation
ezgif.com-gif-maker.mp4