Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

refactor: 🍰 Disable Submit Button On group Update Changed Error #5489

Conversation

ogerly
Copy link
Member

@ogerly ogerly commented Oct 15, 2022

🍰 Pull Request

when update edit a group, disable submit button if data are not according to schema

Issues

@ogerly ogerly added this to the 🏃 The Sprint after that... milestone Oct 15, 2022
@ogerly ogerly requested a review from Tirokk October 15, 2022 06:21
@ogerly ogerly self-assigned this Oct 15, 2022
@ogerly ogerly changed the base branch from master to 5059-epic-groups October 16, 2022 11:05
@Tirokk Tirokk changed the title 5472 disable submit button on group update changed error refactor: 🍰 Disable Submit Button On group Update Changed Error Oct 17, 2022
Tirokk
Tirokk previously requested changes Oct 17, 2022
Copy link
Member

@Tirokk Tirokk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have still some little problems:

  • general:
    • the clear location button is not visible
  • update:
    • if I change anything, but not the location, and save then the location vanishes on the group profile

I'm not sure this is all, but it seems the most imnportant to me.

@ogerly ogerly requested a review from Tirokk October 17, 2022 13:31
@Tirokk Tirokk dismissed their stale review October 18, 2022 17:13

fulfilled

Copy link
Member Author

@ogerly ogerly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Tirokk great, the problem seems to be solved. i have not detected any errors

Copy link
Member

@Tirokk Tirokk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YES 😍🚀💫

@ogerly ogerly merged commit 138f9a1 into 5059-epic-groups Oct 19, 2022
@ogerly ogerly deleted the 5472-Disable-Submit-Button-On-Group-Update-Changed-Error branch October 19, 2022 04:43
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🔧 [Refactor] Disable Submit Button On Update Formular If Nothing Has Changed
3 participants