feat: 🍰 Mobile Footer Menu To Header Menu #5524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezgif.com-gif-maker.3.mp4 |
ogerly
changed the title
ogerly
changed the title
|
the dynamic menu for the header is also displayed if it is present.
|
ogerly
changed the title
|
ok ... i solved it. next to the search input in the header the filter button is only visible on the index. if you move in the network then the filter button disappears ... that's why i didn't see it ... |
Tirokk
changed the title
|
|
ogerly
changed the title
Tirokk
requested changes
Oct 21, 2022
There was a problem hiding this comment.
This looks very nice 😍
- There is a width where the footer is still there and the hamurger-menu appears already. I made a suggestion in the code how to avoid this.
- The space between the items of the header menu should be the same as in the very good looking footer menu, see screenshot.
- Can we get the search field etc. already in the second row if the hamburger-menu appears, see screen shot. If possible, that would be perfect. If not we can life with it for now.
1 task
Co-authored-by: Wolfgang Huß <wolle.huss@pjannto.com>
|
And allow myself to merge, because then I can go more qucikly ahead … |
Tirokk
deleted the
4732-Put-Footer-Content-In-The-Menu-On-Mobil-Phones
branch
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍰 Pull Request
fist step, if mobile, footer menu to heder menu
Issues
Todo